Commit 51e5ad75 authored by Haibo Chen's avatar Haibo Chen Committed by sanglipeng
Browse files

gpio: vf610: set value before the direction to avoid a glitch 

stable inclusion
from stable-v5.10.199
commit 7e29dadf265d28dfc7a0ae3a1069678b642ee2e6
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9AWJ5

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7e29dadf265d28dfc7a0ae3a1069678b642ee2e6



--------------------------------

commit fc363413 upstream.

We found a glitch when configuring the pad as output high. To avoid this
glitch, move the data value setting before direction config in the
function vf610_gpio_direction_output().

Fixes: 659d8a62 ("gpio: vf610: add imx7ulp support")
Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
[Bartosz: tweak the commit message]
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 4318788e

drivers/gpio/gpio-vf610.c

+2 −2
Original line number Diff line number Diff line
@@ -127,14 +127,14 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, 
	unsigned long mask = BIT(gpio);

	u32 val;



	vf610_gpio_set(chip, gpio, value);



	if (port->sdata && port->sdata->have_paddr) {

		val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);

		val |= mask;

		vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);

	}



	vf610_gpio_set(chip, gpio, value);



	return pinctrl_gpio_direction_output(chip->base + gpio);

}