Commit 51c44bab authored Mar 01, 2021 by Wang Qing Committed by Heiko Carstens Mar 08, 2021

s390/cio: return -EFAULT if copy_to_user() fails

The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.

Fixes: e01bcdd6 ("vfio: ccw: realize VFIO_DEVICE_GET_REGION_INFO ioctl")
Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/1614600093-13992-1-git-send-email-wangqing@vivo.com

Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

parent 46b635b6

drivers/s390/cio/vfio_ccw_ops.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -543,7 +543,7 @@ static ssize_t vfio_ccw_mdev_ioctl(struct mdev_device *mdev,
		if (ret)
		return ret;

		return copy_to_user((void __user *)arg, &info, minsz);
		return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
		}
		case VFIO_DEVICE_GET_REGION_INFO:
		{
		@@ -561,7 +561,7 @@ static ssize_t vfio_ccw_mdev_ioctl(struct mdev_device *mdev,
		if (ret)
		return ret;

		return copy_to_user((void __user *)arg, &info, minsz);
		return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
		}
		case VFIO_DEVICE_GET_IRQ_INFO:
		{