Commit 51b02a96 authored Mar 20, 2023 by Leo Yan Committed by Arnaldo Carvalho de Melo Mar 21, 2023

perf kvm: Delete histograms entries before exiting



It's good not to release resources for a program when kernel cleans up
memory space, this patch explicitly releases histograms entries with
hists__delete_entries().

Committer notice:

This helps with memory leak checkers, but may delay exiting a tool by
doing needless linked list traversals freeing lots of objects.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230320061619.29520-2-leo.yan@linaro.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f1e8f259

tools/perf/builtin-kvm.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1528,6 +1528,8 @@ static int kvm_events_live_report(struct perf_kvm_stat *kvm)
		}

		out:
		hists__delete_entries(&kvm_hists.hists);

		if (kvm->timerfd >= 0)
		close(kvm->timerfd);

		@@ -1690,6 +1692,7 @@ static int kvm_events_report_vcpu(struct perf_kvm_stat *kvm)
		kvm_display(kvm);

		exit:
		hists__delete_entries(&kvm_hists.hists);
		return ret;
		}