Commit 51a224ea authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: adp5589-keys - do not explicitly control IRQ for wakeup 

If device is set up as a wakeup source, I2C core configures the interrupt
line as wake IRQ and PM core automatically configures it for waking up the
system on system suspend transition, so we do not have to explicitly call
enable_irq_wake() and disable_irq_wake() in suspend/resume.

Link: https://lore.kernel.org/r/20201120073920.3214492-2-dmitry.torokhov@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 3e35c194

drivers/input/keyboard/adp5589-keys.c

+9 −18
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 
#include <linux/workqueue.h>

#include <linux/errno.h>

#include <linux/pm.h>

#include <linux/pm_wakeirq.h>

#include <linux/platform_device.h>

#include <linux/input.h>

#include <linux/i2c.h>
@@ -1017,31 +1018,21 @@ static int adp5589_probe(struct i2c_client *client, 


static int __maybe_unused adp5589_suspend(struct device *dev)

{

	struct adp5589_kpad *kpad = dev_get_drvdata(dev);

	struct i2c_client *client = kpad->client;



	if (!kpad->input)

		return 0;

	struct i2c_client *client = to_i2c_client(dev);

	struct adp5589_kpad *kpad = i2c_get_clientdata(client);



	if (kpad->input)

		disable_irq(client->irq);



	if (device_may_wakeup(&client->dev))

		enable_irq_wake(client->irq);



	return 0;

}



static int __maybe_unused adp5589_resume(struct device *dev)

{

	struct adp5589_kpad *kpad = dev_get_drvdata(dev);

	struct i2c_client *client = kpad->client;



	if (!kpad->input)

		return 0;



	if (device_may_wakeup(&client->dev))

		disable_irq_wake(client->irq);

	struct i2c_client *client = to_i2c_client(dev);

	struct adp5589_kpad *kpad = i2c_get_clientdata(client);



	if (kpad->input)

		enable_irq(client->irq);



	return 0;