Commit 519f4ed0 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs: replace some -ENOTTY with -EINVAL 



-ENOTTY is returned in case of error in the ioctl arguments themselves,
such as function that doesn't exists.

In all other cases, where the error is in the arguments of the custom
data structures that we define that are passed in the various ioctls,
we need to return -EINVAL.

Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 0a63ac76

drivers/misc/habanalabs/common/command_buffer.c

+1 −1
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data) 
		break;



	default:

		rc = -ENOTTY;

		rc = -EINVAL;

		break;

	}

drivers/misc/habanalabs/common/habanalabs_ioctl.c

+2 −2
Original line number Diff line number Diff line
@@ -693,7 +693,7 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data, 


	default:

		dev_err(dev, "Invalid request %d\n", args->op);

		rc = -ENOTTY;

		rc = -EINVAL;

		break;

	}
@@ -748,7 +748,7 @@ static int hl_debug_ioctl(struct hl_fpriv *hpriv, void *data) 


	default:

		dev_err(hdev->dev, "Invalid request %d\n", args->op);

		rc = -ENOTTY;

		rc = -EINVAL;

		break;

	}

drivers/misc/habanalabs/common/memory.c

+2 −2
Original line number Diff line number Diff line
@@ -2031,7 +2031,7 @@ static int mem_ioctl_no_mmu(struct hl_fpriv *hpriv, union hl_mem_args *args) 


	default:

		dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");

		rc = -ENOTTY;

		rc = -EINVAL;

		break;

	}
@@ -2156,7 +2156,7 @@ int hl_mem_ioctl(struct hl_fpriv *hpriv, void *data) 


	default:

		dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");

		rc = -ENOTTY;

		rc = -EINVAL;

		break;

	}