Commit 519ce2f9 authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

rtlwifi: rtl8192ee: Fix memory leak when loading firmware 



In routine rtl92ee_set_fw_rsvdpagepkt(), the driver allocates an skb, but
never calls rtl_cmd_send_packet(), which will free the buffer. All other
rtlwifi drivers perform this operation correctly.

This problem has been in the driver since it was included in the kernel.
Fortunately, each firmware load only leaks 4 buffers, which likely
explains why it has not previously been detected.

Cc: Stable <stable@vger.kernel.org> # 3.18+
Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 0f61953d

drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c

+4 −2
Original line number Diff line number Diff line
@@ -682,7 +682,7 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) 
	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));

	struct sk_buff *skb = NULL;



	bool rtstatus;

	u32 totalpacketlen;

	u8 u1rsvdpageloc[5] = { 0 };

	bool b_dlok = false;
@@ -768,6 +768,8 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) 
	skb = dev_alloc_skb(totalpacketlen);

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	rtstatus = rtl_cmd_send_packet(hw, skb);

	if (rtstatus)

		b_dlok = true;



	if (b_dlok) {