Commit 519bbbfe authored by Lu Wei's avatar Lu Wei Committed by Zhengchao Shao
Browse files

xfrm6: fix inet6_dev refcount underflow problem 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I84HSL

Reference: https://lore.kernel.org/netdev/CADvbK_euiOKytyFd6KYgNoM5SbDcyz92Li=K7P48H35q1AFxYg@mail.gmail.com/T/



--------------------------------

There are race conditions that may lead to inet6_dev refcount underflow
in xfrm6_dst_destroy() and rt6_uncached_list_flush_dev().

One of the refcount underflow bugs is shown below:
	(cpu 1)                	|	(cpu 2)
xfrm6_dst_destroy()             |
  ...                           |
  in6_dev_put()                 |
				|  rt6_uncached_list_flush_dev()
  ...				|    ...
				|    in6_dev_put()
  rt6_uncached_list_del()       |    ...
  ...                           |

xfrm6_dst_destroy() calls rt6_uncached_list_del() after in6_dev_put(),
so rt6_uncached_list_flush_dev() has a chance to call in6_dev_put()
again for the same inet6_dev.

Fix it by moving in6_dev_put() after rt6_uncached_list_del() in
xfrm6_dst_destroy().

Fixes: 510c321b ("xfrm: reuse uncached_list to track xdsts")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarLu Wei <luwei32@huawei.com>
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
parent b2e20aab

net/ipv6/xfrm6_policy.c

+2 −2
Original line number Diff line number Diff line
@@ -120,11 +120,11 @@ static void xfrm6_dst_destroy(struct dst_entry *dst) 
{

	struct xfrm_dst *xdst = (struct xfrm_dst *)dst;



	if (likely(xdst->u.rt6.rt6i_idev))

		in6_dev_put(xdst->u.rt6.rt6i_idev);

	dst_destroy_metrics_generic(dst);

	if (xdst->u.rt6.rt6i_uncached_list)

		rt6_uncached_list_del(&xdst->u.rt6);

	if (likely(xdst->u.rt6.rt6i_idev))

		in6_dev_put(xdst->u.rt6.rt6i_idev);

	xfrm_dst_destroy(xdst);

}