Commit 519346ec authored Jun 14, 2021 by Siddharth Gupta Committed by Bjorn Andersson Jun 23, 2021

remoteproc: core: Move validate before device add



We can validate whether the remoteproc is correctly setup before
making the cdev_add and device_add calls. This saves us the
trouble of cleaning up later on.

Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/1623723671-5517-3-git-send-email-sidgup@codeaurora.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent c6659ee8

drivers/remoteproc/remoteproc_core.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2333,16 +2333,16 @@ int rproc_add(struct rproc *rproc)
		struct device *dev = &rproc->dev;
		int ret;

		/* add char device for this remoteproc */
		ret = rproc_char_device_add(rproc);
		ret = rproc_validate(rproc);
		if (ret < 0)
		return ret;

		ret = device_add(dev);
		/* add char device for this remoteproc */
		ret = rproc_char_device_add(rproc);
		if (ret < 0)
		return ret;

		ret = rproc_validate(rproc);
		ret = device_add(dev);
		if (ret < 0)
		return ret;