Commit 5161d96d authored by Yi Yang's avatar Yi Yang
Browse files

Revert "tty: fix pid memleak in disassociate_ctty()" 

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7LEZX



--------------------------------

This reverts commit e2944873.

Prepare to backport patch from mainline.

Signed-off-by: default avatarYi Yang <yiyang13@huawei.com>
parent c4c07841

drivers/tty/tty_jobctrl.c

+0 −12
Original line number Diff line number Diff line
@@ -308,18 +308,6 @@ void disassociate_ctty(int on_exit) 
		spin_unlock_irqrestore(&tty->ctrl_lock, flags);

		tty_unlock(tty);

		tty_kref_put(tty);



		/*

		 * Race with tty_signal_session_leader(), current->signal

		 * ->tty_old_pgrp may be reassigned, put_pid() again to ensure

		 *  the pid does not leak memory.

		 */

		if (on_exit) {

			spin_lock_irq(&current->sighand->siglock);

			put_pid(current->signal->tty_old_pgrp);

			current->signal->tty_old_pgrp = NULL;

			spin_unlock_irq(&current->sighand->siglock);

		}

	}



	/* Now clear signal->tty under the lock */