Commit 51526637 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd: Use `amdgpu_ucode_release` helper for DMUB 



The `amdgpu_ucode_release` helper is for symmetry on unloading.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a7ab3451

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+3 −7
Original line number Diff line number Diff line
@@ -1900,8 +1900,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev) 
	if (r) {

		dev_err(adev->dev, "amdgpu_dm: Can't validate firmware \"%s\"\n",

			fw_name_dmcu);

		release_firmware(adev->dm.fw_dmcu);

		adev->dm.fw_dmcu = NULL;

		amdgpu_ucode_release(&adev->dm.fw_dmcu);

		return r;

	}
@@ -2117,11 +2116,8 @@ static int dm_sw_fini(void *handle) 
		adev->dm.dmub_srv = NULL;

	}



	release_firmware(adev->dm.dmub_fw);

	adev->dm.dmub_fw = NULL;



	release_firmware(adev->dm.fw_dmcu);

	adev->dm.fw_dmcu = NULL;

	amdgpu_ucode_release(&adev->dm.dmub_fw);

	amdgpu_ucode_release(&adev->dm.fw_dmcu);



	return 0;

}