Commit 51361684 authored May 04, 2022 by Christoph Hellwig Committed by Jens Axboe May 04, 2022

block: remove superfluous calls to blkcg_bio_issue_init



blkcg_bio_issue_init is called in submit_bio.  There is no need to have
extra calls that just get overriden in __bio_clone and the two places
that copy and pasted from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Link: https://lore.kernel.org/r/20220504142950.567582-2-hch@lst.de


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent f624506f

block/bio.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -768,7 +768,6 @@ static int __bio_clone(struct bio bio, struct bio bio_src, gfp_t gfp)
		bio->bi_iter = bio_src->bi_iter;

		bio_clone_blkg_association(bio, bio_src);
		blkcg_bio_issue_init(bio);

		if (bio_crypt_clone(bio, bio_src, gfp) < 0)
		return -ENOMEM;

block/blk-crypto-fallback.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -179,7 +179,6 @@ static struct bio blk_crypto_fallback_clone_bio(struct bio bio_src)
		bio->bi_io_vec[bio->bi_vcnt++] = bv;

		bio_clone_blkg_association(bio, bio_src);
		blkcg_bio_issue_init(bio);

		return bio;
		}

block/bounce.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -191,7 +191,6 @@ static struct bio bounce_clone_bio(struct bio bio_src)
		goto err_put;

		bio_clone_blkg_association(bio, bio_src);
		blkcg_bio_issue_init(bio);

		return bio;