Commit 5124b31c authored by Corentin Labbe's avatar Corentin Labbe Committed by David S. Miller
Browse files

sparc: piggyback: handle invalid image 



With an old elftoaout, the generation of tftpboot.img fail with "lseek:
invalid argument".
This is due to offset being negative.

Instead of printing this error message, let's print a better one.

Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c05d042f

arch/sparc/boot/piggyback.c

+4 −0
Original line number Diff line number Diff line
@@ -154,6 +154,10 @@ static off_t get_hdrs_offset(int kernelfd, const char *filename) 
		offset -= LOOKBACK;

		/* skip a.out header */

		offset += AOUT_TEXT_OFFSET;

		if (offset < 0) {

			errno = -EINVAL;

			die("Calculated a negative offset, probably elftoaout generated an invalid image. Did you use a recent elftoaout ?");

		}

		if (lseek(kernelfd, offset, SEEK_SET) < 0)

			die("lseek");

		if (read(kernelfd, buffer, BUFSIZE) != BUFSIZE)