Commit 5112e9a5 authored by Harshad Shirwadkar's avatar Harshad Shirwadkar Committed by Theodore Ts'o
Browse files

ext4: fix double locking in ext4_fc_commit_dentry_updates() 



Fixed double locking of sbi->s_fc_lock in the above function
as reported by kernel-test-robot.

Signed-off-by: default avatarHarshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201023161339.1449437-1-harshadshirwadkar@gmail.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 96485e44

fs/ext4/fast_commit.c

+0 −1
Original line number Diff line number Diff line
@@ -964,7 +964,6 @@ static int ext4_fc_commit_dentry_updates(journal_t *journal, u32 *crc) 
			fc_dentry->fcd_parent, fc_dentry->fcd_ino,

			fc_dentry->fcd_name.len,

			fc_dentry->fcd_name.name, crc)) {

			spin_lock(&sbi->s_fc_lock);

			ret = -ENOSPC;

			goto lock_and_exit;

		}