Commit 50f21510 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: img: Use regmap_clear_bits and regmap_set_bits where applicable 

Found using coccinelle and the following semantic patch:

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, bits)
+ regmap_set_bits(map, reg, bits)

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, 0)
+ regmap_clear_bits(map, reg, bits)

Link: https://lore.kernel.org/r/20221115111347.3705732-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent c637d87a

drivers/pwm/pwm-img.c

+7 −8
Original line number Diff line number Diff line
@@ -161,9 +161,9 @@ static int img_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) 
	val |= BIT(pwm->hwpwm);

	img_pwm_writel(imgchip, PWM_CTRL_CFG, val);



	regmap_update_bits(imgchip->periph_regs, PERIP_PWM_PDM_CONTROL,

	regmap_clear_bits(imgchip->periph_regs, PERIP_PWM_PDM_CONTROL,

			  PERIP_PWM_PDM_CONTROL_CH_MASK <<

			   PERIP_PWM_PDM_CONTROL_CH_SHIFT(pwm->hwpwm), 0);

			  PERIP_PWM_PDM_CONTROL_CH_SHIFT(pwm->hwpwm));



	return 0;

}
@@ -397,11 +397,10 @@ static int img_pwm_resume(struct device *dev) 


	for (i = 0; i < imgchip->chip.npwm; i++)

		if (imgchip->suspend_ctrl_cfg & BIT(i))

			regmap_update_bits(imgchip->periph_regs,

			regmap_clear_bits(imgchip->periph_regs,

					  PERIP_PWM_PDM_CONTROL,

					  PERIP_PWM_PDM_CONTROL_CH_MASK <<

					   PERIP_PWM_PDM_CONTROL_CH_SHIFT(i),

					   0);

					  PERIP_PWM_PDM_CONTROL_CH_SHIFT(i));



	if (pm_runtime_status_suspended(dev))

		img_pwm_runtime_suspend(dev);