Unverified Commit 50ac48ae authored by Jernej Skrabec's avatar Jernej Skrabec Committed by Maxime Ripard
Browse files

bus: sun50i-de2: Adjust printing error message 



SRAM driver often returns -EPROBE_DEFER and thus this bus driver often
prints error message, even if it probes successfully later. This is
confusing for users and they often think that something is wrong.

Use dev_err_probe() helper for printing error message. It handles
-EPROBE_DEFER automatically.

Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: default avatarAndre Przywara <andre.przywara@arm.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20211010071812.145178-1-jernej.skrabec@gmail.com
parent 1f3753a5

drivers/bus/sun50i-de2.c

+3 −4
Original line number Diff line number Diff line
@@ -15,10 +15,9 @@ static int sun50i_de2_bus_probe(struct platform_device *pdev) 
	int ret;



	ret = sunxi_sram_claim(&pdev->dev);

	if (ret) {

		dev_err(&pdev->dev, "Error couldn't map SRAM to device\n");

		return ret;

	}

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "Couldn't map SRAM to device\n");



	of_platform_populate(np, NULL, NULL, &pdev->dev);