Commit 5099a722 authored by Marco Elver's avatar Marco Elver Committed by Paul E. McKenney
Browse files

checkpatch: Warn about data_race() without comment 



Warn about applications of data_race() without a comment, to encourage
documenting the reasoning behind why it was deemed safe.

Suggested-by: default avatarWill Deacon <will@kernel.org>
Signed-off-by: default avatarMarco Elver <elver@google.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 52785b6a

scripts/checkpatch.pl

+8 −0
Original line number Original line Diff line number Diff line
@@ -5833,6 +5833,14 @@ sub process { 
			}

			}

		}

		}





# check for data_race without a comment.

		if ($line =~ /\bdata_race\s*\(/) {

			if (!ctx_has_comment($first_line, $linenr)) {

				WARN("DATA_RACE",

				     "data_race without comment\n" . $herecurr);

			}

		}



# check for smp_read_barrier_depends and read_barrier_depends

# check for smp_read_barrier_depends and read_barrier_depends

		if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {

		if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {

			WARN("READ_BARRIER_DEPENDS",

			WARN("READ_BARRIER_DEPENDS",