Commit 507f9860 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Petr Mladek
Browse files

test_printf: Append strings more efficiently 



Use scnprintf instead of snprintf + strlen.

Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Reviewed-by: default avatarYafang Shao <laoar.shao@gmail.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20211019142621.2810043-5-willy@infradead.org
parent 5b358b0d

lib/test_printf.c

+7 −11
Original line number Diff line number Diff line
@@ -614,8 +614,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid, 
	int i;



	if (flags & PAGEFLAGS_MASK) {

		snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);

		size = strlen(cmp_buf);

		size += scnprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);

		append = true;

	}
@@ -623,17 +622,14 @@ page_flags_test(int section, int node, int zone, int last_cpupid, 
		if (!pft[i].width)

			continue;



		if (append) {

			snprintf(cmp_buf + size, BUF_SIZE - size, "|");

			size = strlen(cmp_buf);

		}

		if (append)

			size += scnprintf(cmp_buf + size, BUF_SIZE - size, "|");



		flags |= (values[i] & pft[i].mask) << pft[i].shift;

		snprintf(cmp_buf + size, BUF_SIZE - size, "%s=", pft[i].name);

		size = strlen(cmp_buf);

		snprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt,

		size += scnprintf(cmp_buf + size, BUF_SIZE - size, "%s=",

				pft[i].name);

		size += scnprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt,

				values[i] & pft[i].mask);

		size = strlen(cmp_buf);

		append = true;

	}