Commit 505a27a7 authored by John Ogness's avatar John Ogness Committed by Petr Mladek
Browse files

printk: console: remove unnecessary safe buffer usage 



Upon registering a console, safe buffers are activated when setting
up the sequence number to replay the log. However, these are already
protected by @console_sem and @syslog_lock. Remove the unnecessary
safe buffer usage.

Signed-off-by: default avatarJohn Ogness <john.ogness@linutronix.de>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210303101528.29901-16-john.ogness@linutronix.de
parent a4f98765

kernel/printk/printk.c

+3 −7
Original line number Diff line number Diff line
@@ -2967,9 +2967,7 @@ void register_console(struct console *newcon) 
		/*

		 * console_unlock(); will print out the buffered messages

		 * for us.

		 */

		printk_safe_enter_irqsave(flags);

		/*

		 *

		 * We're about to replay the log buffer.  Only do this to the

		 * just-registered console to avoid excessive message spam to

		 * the already-registered consoles.
@@ -2982,11 +2980,9 @@ void register_console(struct console *newcon) 
		exclusive_console_stop_seq = console_seq;



		/* Get a consistent copy of @syslog_seq. */

		raw_spin_lock(&syslog_lock);

		raw_spin_lock_irqsave(&syslog_lock, flags);

		console_seq = syslog_seq;

		raw_spin_unlock(&syslog_lock);



		printk_safe_exit_irqrestore(flags);

		raw_spin_unlock_irqrestore(&syslog_lock, flags);

	}

	console_unlock();

	console_sysfs_notify();