Commit 50467203 authored Jun 08, 2021 by Sergey Ryazanov Committed by David S. Miller Jun 08, 2021

net: wwan: core: purge rx queue on port close



Purge the rx queue as soon as a user closes the port, just after the
port stop callback invocation. This is to prevent feeding a user that
will open the port next time with outdated and possibly unrelated
data.

While at it also remove the odd skb_queue_purge() call in the port
device destroy callback. The queue will be purged just before the
callback is ivoncated in the wwan_remove_port() function.

Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c230035c

drivers/net/wwan/wwan_core.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -240,7 +240,6 @@ static void wwan_port_destroy(struct device *dev)

		ida_free(&minors, MINOR(port->dev.devt));
		mutex_destroy(&port->data_lock);
		skb_queue_purge(&port->rxq);
		mutex_destroy(&port->ops_lock);
		kfree(port);
		}
		@@ -462,8 +461,11 @@ static void wwan_port_op_stop(struct wwan_port *port)
		{
		mutex_lock(&port->ops_lock);
		port->start_count--;
		if (port->ops && !port->start_count)
		if (!port->start_count) {
		if (port->ops)
		port->ops->stop(port);
		skb_queue_purge(&port->rxq);
		}
		mutex_unlock(&port->ops_lock);
		}