Commit 503f418b authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Greg Kroah-Hartman
Browse files

serial: fsl_lpuart: Remove unnecessary clearing for CRTSCTS 



if (termios->c_cflag & CRTSCTS) guarantees that CRTSCTS is not ever set
in the else block so clearing it is unnecessary.

While at it, remove also one pair of extra parenthesis.

Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220513082906.11096-5-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9cca25e2

drivers/tty/serial/fsl_lpuart.c

+3 −5
Original line number Diff line number Diff line
@@ -2110,12 +2110,10 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios, 
	if (sport->port.rs485.flags & SER_RS485_ENABLED)

		termios->c_cflag &= ~CRTSCTS;



	if (termios->c_cflag & CRTSCTS) {

		modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);

	} else {

		termios->c_cflag &= ~CRTSCTS;

	if (termios->c_cflag & CRTSCTS)

		modem |= UARTMODIR_RXRTSE | UARTMODIR_TXCTSE;

	else

		modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);

	}



	if (termios->c_cflag & CSTOPB)

		bd |= UARTBAUD_SBNS;