Commit 4ff0b50d authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring/rsrc: fix rogue rsrc node grabbing 



We should not be looking at ctx->rsrc_node and anyhow modifying the node
without holding uring_lock, grabbing references in such a way is not
safe either.

Cc: stable@vger.kernel.org
Fixes: 5106dd6e ("io_uring: propagate issue_flags state down to file assignment")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/1202ede2d7bb90136e3482b2b84aad9ed483e5d6.1680098433.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 005308f7

io_uring/rsrc.h

+5 −7
Original line number Diff line number Diff line
@@ -144,15 +144,13 @@ static inline void io_req_set_rsrc_node(struct io_kiocb *req, 
					unsigned int issue_flags)

{

	if (!req->rsrc_node) {

		req->rsrc_node = ctx->rsrc_node;

		io_ring_submit_lock(ctx, issue_flags);



		if (!(issue_flags & IO_URING_F_UNLOCKED)) {

		lockdep_assert_held(&ctx->uring_lock);



		req->rsrc_node = ctx->rsrc_node;

		io_charge_rsrc_node(ctx);

		} else {

			percpu_ref_get(&req->rsrc_node->refs);

		}

		io_ring_submit_unlock(ctx, issue_flags);

	}

}