Commit 4fea96af authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Miquel Raynal
Browse files

mtd: dataflash: Warn about failure to unregister mtd device 



mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.

This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().

By returning 0 in the spi remove callback a generic error message by the
spi framework (and nothing else) is suppressed.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211108093153.63792-1-u.kleine-koenig@pengutronix.de
parent c048b60d

drivers/mtd/devices/mtd_dataflash.c

+5 −5
Original line number Diff line number Diff line
@@ -912,14 +912,14 @@ static int dataflash_probe(struct spi_device *spi) 
static int dataflash_remove(struct spi_device *spi)

{

	struct dataflash	*flash = spi_get_drvdata(spi);

	int			status;



	dev_dbg(&spi->dev, "remove\n");



	status = mtd_device_unregister(&flash->mtd);

	if (status == 0)

	WARN_ON(mtd_device_unregister(&flash->mtd));



	kfree(flash);

	return status;



	return 0;

}



static struct spi_driver dataflash_driver = {