Commit 4fdb28d8 authored May 11, 2019 by liyangyang20 Committed by Xie XiuQi Dec 27, 2019

RDMA/hns: Fix a static checker warning for hip08



driver inclusion
category: bugfix
bugzilla: NA
CVE: NA

Dan Carpenter provide a bug report about the patch 6a04aed6:
"RDMA/hns: Fix the chip hanging caused by sending mailbox&CMQ
during reset" from Feb 3, 2019, which leads to the
following static checker warning:

drivers/infiniband/hw/hns/hns_roce_qp.c:940 hns_roce_create_qp()
error: passing non negative 2 to ERR_PTR

The number "2" comes from hns_roce_cmq_send(), These should be -EBUSY.

Feature or Bugfix:Bugfix

Signed-off-by: liyangyang (M) <liyangyang20@huawei.com>
Reviewed-by: oulijun <oulijun@huawei.com>
Reviewed-by: liuyixian <liuyixian@huawei.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

parent 08642c11

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1154,7 +1154,7 @@ int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
		if (ret == CMD_RST_PRC_SUCCESS)
		return 0;
		if (ret == CMD_RST_PRC_EBUSY)
		return ret;
		return -EBUSY;

		ret = __hns_roce_cmq_send(hr_dev, desc, num);
		if (ret) {
		@@ -1162,7 +1162,7 @@ int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
		if (retval == CMD_RST_PRC_SUCCESS)
		return 0;
		else if (retval == CMD_RST_PRC_EBUSY)
		return retval;
		return -EBUSY;
		}

		return ret;