Commit 4fd62973 authored by Deepak R Varma's avatar Deepak R Varma Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Use a variable for repeated mem_size computation 

Use a variable to compute memory size to be allocated once instead of
repeatedly computing it at different locations in the function. Issue
identified using the array_size_dup Coccinelle semantic patch.

Link: https://lore.kernel.org/r/Y7spwF8HTt0c0l7y@ubun2204.myguest.virtualbox.org


Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2aa0f83e

drivers/scsi/qla2xxx/tcm_qla2xxx.c

+6 −7
Original line number Diff line number Diff line
@@ -1552,6 +1552,7 @@ static const struct qla_tgt_func_tmpl tcm_qla2xxx_template = { 
static int tcm_qla2xxx_init_lport(struct tcm_qla2xxx_lport *lport)

{

	int rc;

	size_t map_sz;



	rc = btree_init32(&lport->lport_fcport_map);

	if (rc) {
@@ -1559,17 +1560,15 @@ static int tcm_qla2xxx_init_lport(struct tcm_qla2xxx_lport *lport) 
		return rc;

	}



	lport->lport_loopid_map =

		vzalloc(array_size(65536,

				   sizeof(struct tcm_qla2xxx_fc_loopid)));

	map_sz = array_size(65536, sizeof(struct tcm_qla2xxx_fc_loopid));



	lport->lport_loopid_map = vzalloc(map_sz);

	if (!lport->lport_loopid_map) {

		pr_err("Unable to allocate lport->lport_loopid_map of %zu bytes\n",

		    sizeof(struct tcm_qla2xxx_fc_loopid) * 65536);

		pr_err("Unable to allocate lport->lport_loopid_map of %zu bytes\n", map_sz);

		btree_destroy32(&lport->lport_fcport_map);

		return -ENOMEM;

	}

	pr_debug("qla2xxx: Allocated lport_loopid_map of %zu bytes\n",

	       sizeof(struct tcm_qla2xxx_fc_loopid) * 65536);

	pr_debug("qla2xxx: Allocated lport_loopid_map of %zu bytes\n", map_sz);

	return 0;

}