Commit 4fb5ad61 authored by Thomas Zimmermann's avatar Thomas Zimmermann Committed by Dmitry Baryshkov
Browse files

drm/msm: Use struct fb_info.screen_buffer 



The fbdev framebuffer is in system memory. Store the address in
the field 'screen_buffer'. Fixes the following sparse warning.

../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
../drivers/gpu/drm/msm/msm_fbdev.c:124:26:    expected char [noderef] __iomem *screen_base
../drivers/gpu/drm/msm/msm_fbdev.c:124:26:    got void *

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/538531/
Link: https://lore.kernel.org/r/20230522191701.13406-1-tzimmermann@suse.de


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 3bc7fb9a

drivers/gpu/drm/msm/msm_fbdev.c

+3 −3
Original line number Diff line number Diff line
@@ -121,9 +121,9 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, 


	drm_fb_helper_fill_info(fbi, helper, sizes);



	fbi->screen_base = msm_gem_get_vaddr(bo);

	if (IS_ERR(fbi->screen_base)) {

		ret = PTR_ERR(fbi->screen_base);

	fbi->screen_buffer = msm_gem_get_vaddr(bo);

	if (IS_ERR(fbi->screen_buffer)) {

		ret = PTR_ERR(fbi->screen_buffer);

		goto fail;

	}

	fbi->screen_size = bo->size;