Commit 4fad22a1 authored by Yuan Can's avatar Yuan Can Committed by Paolo Abeni
Browse files

dpaa2-switch: Fix memory leak in dpaa2_switch_acl_entry_add() and dpaa2_switch_acl_entry_remove() 



The cmd_buff needs to be freed when error happened in
dpaa2_switch_acl_entry_add() and dpaa2_switch_acl_entry_remove().

Fixes: 1110318d ("dpaa2-switch: add tc flower hardware offload on ingress traffic")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20221205061515.115012-1-yuancan@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 063a932b

drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c

+4 −0
Original line number Diff line number Diff line
@@ -132,6 +132,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block, 
						 DMA_TO_DEVICE);

	if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {

		dev_err(dev, "DMA mapping failed\n");

		kfree(cmd_buff);

		return -EFAULT;

	}
@@ -142,6 +143,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block, 
			 DMA_TO_DEVICE);

	if (err) {

		dev_err(dev, "dpsw_acl_add_entry() failed %d\n", err);

		kfree(cmd_buff);

		return err;

	}
@@ -172,6 +174,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block, 
						 DMA_TO_DEVICE);

	if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {

		dev_err(dev, "DMA mapping failed\n");

		kfree(cmd_buff);

		return -EFAULT;

	}
@@ -182,6 +185,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block, 
			 DMA_TO_DEVICE);

	if (err) {

		dev_err(dev, "dpsw_acl_remove_entry() failed %d\n", err);

		kfree(cmd_buff);

		return err;

	}