Commit 4f547472 authored by Jens Glathe's avatar Jens Glathe Committed by Greg Kroah-Hartman
Browse files

usb: xhci: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller 

This appears to fix the error:
"xhci_hcd <address>; ERROR Transfer event TRB DMA ptr not part of
current TD ep_index 2 comp_code 13" that appear spuriously (or pretty
often) when using a r8152 USB3 ethernet adapter with integrated hub.

ASM1042 reports as a 0.96 controller, but appears to behave more like 1.0

Inspired by this email thread: https://markmail.org/thread/7vzqbe7t6du6qsw3



Cc: stable@vger.kernel.org
Signed-off-by: default avatarJens Glathe <jens.glathe@oldschoolsolutions.biz>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20221024142720.4122053-2-mathias.nyman@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3f53c329

drivers/usb/host/xhci-pci.c

+7 −1
Original line number Diff line number Diff line
@@ -306,8 +306,14 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) 
	}



	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&

		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)

		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) {

		/*

		 * try to tame the ASMedia 1042 controller which reports 0.96

		 * but appears to behave more like 1.0

		 */

		xhci->quirks |= XHCI_SPURIOUS_SUCCESS;

		xhci->quirks |= XHCI_BROKEN_STREAMS;

	}

	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&

		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) {

		xhci->quirks |= XHCI_TRUST_TX_LENGTH;