Commit 4f521bab authored by Maninder Singh's avatar Maninder Singh Committed by Luis Chamberlain
Browse files

kallsyms: remove unsed API lookup_symbol_attrs 



with commit '7878c231 ("slab: remove /proc/slab_allocators")'
lookup_symbol_attrs usage is removed.

Thus removing redundant API.

Signed-off-by: default avatarManinder Singh <maninder1.s@samsung.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent 15d5daa0

include/linux/kallsyms.h

+0 −6
Original line number Diff line number Diff line
@@ -93,7 +93,6 @@ extern int sprint_backtrace(char *buffer, unsigned long address); 
extern int sprint_backtrace_build_id(char *buffer, unsigned long address);



int lookup_symbol_name(unsigned long addr, char *symname);

int lookup_symbol_attrs(unsigned long addr, unsigned long *size, unsigned long *offset, char *modname, char *name);



/* How and when do we show kallsyms values? */

extern bool kallsyms_show_value(const struct cred *cred);
@@ -155,11 +154,6 @@ static inline int lookup_symbol_name(unsigned long addr, char *symname) 
	return -ERANGE;

}



static inline int lookup_symbol_attrs(unsigned long addr, unsigned long *size, unsigned long *offset, char *modname, char *name)

{

	return -ERANGE;

}



static inline bool kallsyms_show_value(const struct cred *cred)

{

	return false;

include/linux/module.h

+0 −9
Original line number Diff line number Diff line
@@ -968,15 +968,6 @@ static inline int lookup_module_symbol_name(unsigned long addr, char *symname) 
	return -ERANGE;

}



static inline int lookup_module_symbol_attrs(unsigned long addr,

					     unsigned long *size,

					     unsigned long *offset,

					     char *modname,

					     char *name)

{

	return -ERANGE;

}



static inline int module_get_kallsym(unsigned int symnum, unsigned long *value,

				     char *type, char *name,

				     char *module_name, int *exported)

kernel/kallsyms.c

+0 −28
Original line number Diff line number Diff line
@@ -484,34 +484,6 @@ int lookup_symbol_name(unsigned long addr, char *symname) 
	return 0;

}



int lookup_symbol_attrs(unsigned long addr, unsigned long *size,

			unsigned long *offset, char *modname, char *name)

{

	int res;



	name[0] = '\0';

	name[KSYM_NAME_LEN - 1] = '\0';



	if (is_ksym_addr(addr)) {

		unsigned long pos;



		pos = get_symbol_pos(addr, size, offset);

		/* Grab name */

		kallsyms_expand_symbol(get_symbol_offset(pos),

				       name, KSYM_NAME_LEN);

		modname[0] = '\0';

		goto found;

	}

	/* See if it's in a module. */

	res = lookup_module_symbol_attrs(addr, size, offset, modname, name);

	if (res)

		return res;



found:

	cleanup_symbol_name(name);

	return 0;

}



/* Look up a kernel symbol and return it in a text buffer. */

static int __sprint_symbol(char *buffer, unsigned long address,

			   int symbol_offset, int add_offset, int add_buildid)

kernel/module/kallsyms.c

+0 −28
Original line number Diff line number Diff line
@@ -381,34 +381,6 @@ int lookup_module_symbol_name(unsigned long addr, char *symname) 
	return -ERANGE;

}



int lookup_module_symbol_attrs(unsigned long addr, unsigned long *size,

			       unsigned long *offset, char *modname, char *name)

{

	struct module *mod;



	preempt_disable();

	list_for_each_entry_rcu(mod, &modules, list) {

		if (mod->state == MODULE_STATE_UNFORMED)

			continue;

		if (within_module(addr, mod)) {

			const char *sym;



			sym = find_kallsyms_symbol(mod, addr, size, offset);

			if (!sym)

				goto out;

			if (modname)

				strscpy(modname, mod->name, MODULE_NAME_LEN);

			if (name)

				strscpy(name, sym, KSYM_NAME_LEN);

			preempt_enable();

			return 0;

		}

	}

out:

	preempt_enable();

	return -ERANGE;

}



int module_get_kallsym(unsigned int symnum, unsigned long *value, char *type,

		       char *name, char *module_name, int *exported)

{