Unverified Commit 4f4e0454 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

ASoC: mediatek: Fix error handling in mt8173_max98090_dev_probe 



Call of_node_put(platform_node) to avoid refcount leak in
the error path.

Fixes: 94319ba1 ("ASoC: mediatek: Use platform_of_node for machine drivers")
Fixes: 49343378 ("ASoC: mediatek: mt8173: fix device_node leak")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220404092903.26725-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9a2c9841

sound/soc/mediatek/mt8173/mt8173-max98090.c

+4 −1
Original line number Diff line number Diff line
@@ -167,7 +167,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev) 
	if (!codec_node) {

		dev_err(&pdev->dev,

			"Property 'audio-codec' missing or invalid\n");

		return -EINVAL;

		ret = -EINVAL;

		goto put_platform_node;

	}

	for_each_card_prelinks(card, i, dai_link) {

		if (dai_link->codecs->name)
@@ -179,6 +180,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev) 
	ret = devm_snd_soc_register_card(&pdev->dev, card);



	of_node_put(codec_node);



put_platform_node:

	of_node_put(platform_node);

	return ret;

}