Commit 4f350284 authored by Yu Kuai's avatar Yu Kuai Committed by Song Liu
Browse files

md/raid10: fix improper BUG_ON() in raise_barrier() 



'conf->barrier' is protected by 'conf->resync_lock', reading
'conf->barrier' without holding the lock is wrong.

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Acked-by: default avatarGuoqing Jiang <guoqing.jiang@linux.dev>
Signed-off-by: default avatarSong Liu <song@kernel.org>
parent 0c0be98b

drivers/md/raid10.c

+1 −1
Original line number Diff line number Diff line
@@ -936,8 +936,8 @@ static void flush_pending_writes(struct r10conf *conf) 


static void raise_barrier(struct r10conf *conf, int force)

{

	BUG_ON(force && !conf->barrier);

	spin_lock_irq(&conf->resync_lock);

	BUG_ON(force && !conf->barrier);



	/* Wait until no block IO is waiting (unless 'force') */

	wait_event_lock_irq(conf->wait_barrier, force || !conf->nr_waiting,