Commit 4f289826 authored by Herbert Xu's avatar Herbert Xu
Browse files

crypto: caam - Avoid GCC memset bug warning 

Certain versions of gcc don't like the memcpy with a NULL dst
(which only happens with a zero length).  This only happens
when debugging is enabled so add an if clause to work around
these warnings.

A similar warning used to be generated by sparse but that was
fixed years ago.

Link: https://lore.kernel.org/lkml/202210290446.qBayTfzl-lkp@intel.com


Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarKees Cook <keescook@chromium.org>
Reported-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 7361d1bc

drivers/crypto/caam/desc_constr.h

+2 −1
Original line number Diff line number Diff line
@@ -163,7 +163,8 @@ static inline void append_data(u32 * const desc, const void *data, int len) 
{

	u32 *offset = desc_end(desc);



	if (len) /* avoid sparse warning: memcpy with byte count of 0 */

	/* Avoid gcc warning: memcpy with data == NULL */

	if (!IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_DEBUG) || data)

		memcpy(offset, data, len);



	(*desc) = cpu_to_caam32(caam32_to_cpu(*desc) +