Unverified Commit 4f1e50d6 authored by Mark Brown's avatar Mark Brown
Browse files

ASoC: ops: Reject out of bounds values in snd_soc_put_volsw_sx() 



We don't currently validate that the values being set are within the range
we advertised to userspace as being valid, do so and reject any values
that are out of range.

Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220124153253.3548853-3-broonie@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 817f7c93

sound/soc/soc-ops.c

+8 −1
Original line number Diff line number Diff line
@@ -423,8 +423,15 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol, 
	int err = 0;

	unsigned int val, val_mask;



	val = ucontrol->value.integer.value[0];

	if (mc->platform_max && val > mc->platform_max)

		return -EINVAL;

	if (val > max - min)

		return -EINVAL;

	if (val < 0)

		return -EINVAL;

	val_mask = mask << shift;

	val = (ucontrol->value.integer.value[0] + min) & mask;

	val = (val + min) & mask;

	val = val << shift;



	err = snd_soc_component_update_bits(component, reg, val_mask, val);