Commit 4f17344e authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

nvme: remove the NVME_NS_DEAD check in nvme_remove_invalid_namespaces 



The NVME_NS_DEAD check only made sense when we revalidated namespaces
in nvme_passthrough_end for commands that affected the namespace inventory.
These days NVME_NS_DEAD is only set during reset or when tearing down
namespaces, and we always remove all namespaces right after that.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20221101150050.3510-5-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 23a90864

drivers/nvme/host/core.c

+1 −1
Original line number Diff line number Diff line
@@ -4407,7 +4407,7 @@ static void nvme_remove_invalid_namespaces(struct nvme_ctrl *ctrl, 


	down_write(&ctrl->namespaces_rwsem);

	list_for_each_entry_safe(ns, next, &ctrl->namespaces, list) {

		if (ns->head->ns_id > nsid || test_bit(NVME_NS_DEAD, &ns->flags))

		if (ns->head->ns_id > nsid)

			list_move_tail(&ns->list, &rm_list);

	}

	up_write(&ctrl->namespaces_rwsem);