Commit 4efa8e31 authored by Shang XiaoJing's avatar Shang XiaoJing Committed by Arnaldo Carvalho de Melo
Browse files

perf c2c: Prevent potential memory leak in c2c_he_zalloc() 



Free allocated resources when zalloc() fails for members in c2c_he, to
prevent potential memory leak in c2c_he_zalloc().

Signed-off-by: default avatarShang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: default avatarLeo Yan <leo.yan@linaro.org>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220906032906.21395-4-shangxiaojing@huawei.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 6ea9da51

tools/perf/builtin-c2c.c

+9 −3
Original line number Diff line number Diff line
@@ -146,15 +146,15 @@ static void *c2c_he_zalloc(size_t size) 


	c2c_he->cpuset = bitmap_zalloc(c2c.cpus_cnt);

	if (!c2c_he->cpuset)

		return NULL;

		goto out_free;



	c2c_he->nodeset = bitmap_zalloc(c2c.nodes_cnt);

	if (!c2c_he->nodeset)

		return NULL;

		goto out_free;



	c2c_he->node_stats = zalloc(c2c.nodes_cnt * sizeof(*c2c_he->node_stats));

	if (!c2c_he->node_stats)

		return NULL;

		goto out_free;



	init_stats(&c2c_he->cstats.lcl_hitm);

	init_stats(&c2c_he->cstats.rmt_hitm);
@@ -163,6 +163,12 @@ static void *c2c_he_zalloc(size_t size) 
	init_stats(&c2c_he->cstats.load);



	return &c2c_he->he;



out_free:

	free(c2c_he->nodeset);

	free(c2c_he->cpuset);

	free(c2c_he);

	return NULL;

}



static void c2c_he_free(void *he)