Unverified Commit 4eeed5f4 authored by Souptick Joarder's avatar Souptick Joarder Committed by Mark Brown
Browse files

ASoC: soc-pcm: return correct -ERRNO in failure path 



Kernel test robot throws below error ->

sound/soc/soc-pcm.c:2523 dpcm_run_update_startup() error: uninitialized
symbol 'ret'.

Initializing ret = 0 and returning correct -ERRNO in failure path.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarSouptick Joarder <jrdr.linux@gmail.com>
Link: https://lore.kernel.org/r/1610163901-5523-1-git-send-email-jrdr.linux@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5a15cd7f

sound/soc/soc-pcm.c

+2 −1
Original line number Diff line number Diff line
@@ -2432,7 +2432,7 @@ static int dpcm_run_update_startup(struct snd_soc_pcm_runtime *fe, int stream) 
		snd_soc_dpcm_get_substream(fe, stream);

	struct snd_soc_dpcm *dpcm;

	enum snd_soc_dpcm_trigger trigger = fe->dai_link->trigger[stream];

	int ret;

	int ret = 0;

	unsigned long flags;



	dev_dbg(fe->dev, "ASoC: runtime %s open on FE %s\n",
@@ -2441,6 +2441,7 @@ static int dpcm_run_update_startup(struct snd_soc_pcm_runtime *fe, int stream) 
	/* Only start the BE if the FE is ready */

	if (fe->dpcm[stream].state == SND_SOC_DPCM_STATE_HW_FREE ||

		fe->dpcm[stream].state == SND_SOC_DPCM_STATE_CLOSE) {

		ret = -EINVAL;

		dev_err(fe->dev, "ASoC: FE %s is not ready %d\n",

			fe->dai_link->name, fe->dpcm[stream].state);

		goto disconnect;