Commit 4eedb77a authored May 17, 2013 by Paul Bolle Committed by Ingo Molnar May 28, 2013

locking: Fix copy/paste errors of "ARCH_INLINE_*_UNLOCK_BH"



The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ,
ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added
in v2.6.33, but have never actually been used. Ingo Molnar spotted that
this is caused by three identical copy/paste erros. Eg, the Kconfig
entry for

    INLINE_READ_UNLOCK_IRQ

has an (optional) dependency on:

    ARCH_INLINE_READ_UNLOCK_BH

were it apparently should depend on:

    ARCH_INLINE_READ_UNLOCK_IRQ

instead. Likewise for the Kconfig entries for INLINE_SPIN_UNLOCK_IRQ and
INLINE_WRITE_UNLOCK_IRQ. Fix these three errors.

This never really caused any real problems as these symbols are set (or
unset) in a group - but it's worth fixing it nevertheless.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1368780693.1350.228.camel@x61.thuisdomein


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent e4aa937e

kernel/Kconfig.locks

+3 −3

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ config INLINE_SPIN_UNLOCK_BH

		config INLINE_SPIN_UNLOCK_IRQ
		def_bool y
		depends on !PREEMPT \|\| ARCH_INLINE_SPIN_UNLOCK_BH
		depends on !PREEMPT \|\| ARCH_INLINE_SPIN_UNLOCK_IRQ

		config INLINE_SPIN_UNLOCK_IRQRESTORE
		def_bool y
		@@ -175,7 +175,7 @@ config INLINE_READ_UNLOCK_BH

		config INLINE_READ_UNLOCK_IRQ
		def_bool y
		depends on !PREEMPT \|\| ARCH_INLINE_READ_UNLOCK_BH
		depends on !PREEMPT \|\| ARCH_INLINE_READ_UNLOCK_IRQ

		config INLINE_READ_UNLOCK_IRQRESTORE
		def_bool y
		@@ -212,7 +212,7 @@ config INLINE_WRITE_UNLOCK_BH

		config INLINE_WRITE_UNLOCK_IRQ
		def_bool y
		depends on !PREEMPT \|\| ARCH_INLINE_WRITE_UNLOCK_BH
		depends on !PREEMPT \|\| ARCH_INLINE_WRITE_UNLOCK_IRQ

		config INLINE_WRITE_UNLOCK_IRQRESTORE
		def_bool y