Commit 4eec66c0 authored Jan 11, 2021 by Rodrigo Siqueira Committed by Alex Deucher Jan 14, 2021

Revert "drm/amd/display: Fixed Intermittent blue screen on OLED panel"

commit a861736d ("drm/amd/display: Fixed Intermittent blue screen on OLED panel")

causes power regression for many users. It seems that this change causes
the MCLK to get forced high; this creates a regression for many users
since their devices were not able to drop to a low state after this
change. For this reason, this reverts commit
a861736d.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1407


Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Naveed Ashfaq <Naveed.Ashfaq@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Roman Li <roman.li@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org

parent 9d03bb10

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -2635,15 +2635,16 @@ static void dml20v2_DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndP
		}

		if (mode_lib->vba.DRAMClockChangeSupportsVActive &&
		mode_lib->vba.MinActiveDRAMClockChangeMargin > 60 &&
		mode_lib->vba.PrefetchMode[mode_lib->vba.VoltageLevel][mode_lib->vba.maxMpcComb] == 0) {
		mode_lib->vba.MinActiveDRAMClockChangeMargin > 60) {
		mode_lib->vba.DRAMClockChangeWatermark += 25;

		for (k = 0; k < mode_lib->vba.NumberOfActivePlanes; ++k) {
		if (mode_lib->vba.PrefetchMode[mode_lib->vba.VoltageLevel][mode_lib->vba.maxMpcComb] == 0) {
		if (mode_lib->vba.DRAMClockChangeWatermark >
		dml_max(mode_lib->vba.StutterEnterPlusExitWatermark, mode_lib->vba.UrgentWatermark))
		mode_lib->vba.MinTTUVBlank[k] += 25;
		}
		}

		mode_lib->vba.DRAMClockChangeSupport[0][0] = dm_dram_clock_change_vactive;
		} else if (mode_lib->vba.DummyPStateCheck &&