Commit 4ed57c97 authored by Lucas Stach's avatar Lucas Stach Committed by Shawn Guo
Browse files

soc: imx: gpcv2: move to more ideomatic error handling in probe 



Switch to "goto out..." error handling in domain driver probe to
avoid repeating all the error paths.

Tested-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Reviewed-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: default avatarAdam Ford <aford173@gmail.com>
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 6efb943b

drivers/soc/imx/gpcv2.c

+9 −4
Original line number Diff line number Diff line
@@ -502,17 +502,22 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) 
	ret = pm_genpd_init(&domain->genpd, NULL, true);

	if (ret) {

		dev_err(domain->dev, "Failed to init power domain\n");

		imx_pgc_put_clocks(domain);

		return ret;

		goto out_put_clocks;

	}



	ret = of_genpd_add_provider_simple(domain->dev->of_node,

					   &domain->genpd);

	if (ret) {

		dev_err(domain->dev, "Failed to add genpd provider\n");

		goto out_genpd_remove;

	}



	return 0;



out_genpd_remove:

	pm_genpd_remove(&domain->genpd);

out_put_clocks:

	imx_pgc_put_clocks(domain);

	}



	return ret;

}