Commit 4ecd704a authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Linus Torvalds
Browse files

tpm, tpm_tis: correct tpm_tis_flags enumeration values



With commit 858e8b79 ("tpm, tpm_tis: Avoid cache incoherency in test
for interrupts") bit accessor functions are used to access flags in
tpm_tis_data->flags.

However these functions expect bit numbers, while the flags are defined
as bit masks in enum tpm_tis_flag.

Fix this inconsistency by using numbers instead of masks also for the
flags in the enum.

Reported-by: default avatarPavel Machek <pavel@denx.de>
Fixes: 858e8b79 ("tpm, tpm_tis: Avoid cache incoherency in test for interrupts")
Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarPavel Machek <pavel@denx.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6d7d0603
Loading
Loading
Loading
Loading
+4 −4
Original line number Diff line number Diff line
@@ -84,10 +84,10 @@ enum tis_defaults {
#define ILB_REMAP_SIZE			0x100

enum tpm_tis_flags {
	TPM_TIS_ITPM_WORKAROUND		= BIT(0),
	TPM_TIS_INVALID_STATUS		= BIT(1),
	TPM_TIS_DEFAULT_CANCELLATION	= BIT(2),
	TPM_TIS_IRQ_TESTED		= BIT(3),
	TPM_TIS_ITPM_WORKAROUND		= 0,
	TPM_TIS_INVALID_STATUS		= 1,
	TPM_TIS_DEFAULT_CANCELLATION	= 2,
	TPM_TIS_IRQ_TESTED		= 3,
};

struct tpm_tis_data {