Commit 4ec7b666 authored by Justin Stitt's avatar Justin Stitt Committed by Sebastian Reichel
Browse files

power: vexpress: fix -Wvoid-pointer-to-enum-cast warning 

When building with clang 18 I see the following warning:
|       drivers/power/reset/vexpress-poweroff.c:124:10: warning: cast to smaller integer type 'enum vexpress_reset_func' from 'const void *' [-Wvoid-pointer-to-enum-cast]
|         124 |         switch ((enum vexpress_reset_func)match->data) {

This is due to the fact that `match->data` is a void* while `enum vexpress_reset_func`
has the size of an int. This leads to truncation and possible data loss.

Link: https://github.com/ClangBuiltLinux/linux/issues/1910


Reported-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarJustin Stitt <justinstitt@google.com>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 926ce6ba

drivers/power/reset/vexpress-poweroff.c

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static int vexpress_reset_probe(struct platform_device *pdev) 
		return PTR_ERR(regmap);

	dev_set_drvdata(&pdev->dev, regmap);



	switch ((enum vexpress_reset_func)match->data) {

	switch ((uintptr_t)match->data) {

	case FUNC_SHUTDOWN:

		vexpress_power_off_device = &pdev->dev;

		pm_power_off = vexpress_power_off;