Commit 4ebd4703 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: seq: Use bool for snd_seq_queue internal flags 



The snd_seq_queue struct contains various flags in the bit fields.
Those are categorized to two different use cases, both of which are
protected by different spinlocks.  That implies that there are still
potential risks of the bad operations for bit fields by concurrent
accesses.

For addressing the problem, this patch rearranges those flags to be
a standard bool instead of a bit field.

Reported-by: default avatar <syzbot+63cbe31877bb80ef58f5@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/r/20201206083456.21110-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2c854e5c

sound/core/seq/seq_queue.h

+4 −4
Original line number Diff line number Diff line
@@ -26,10 +26,10 @@ struct snd_seq_queue { 
	

	struct snd_seq_timer *timer;	/* time keeper for this queue */

	int	owner;		/* client that 'owns' the timer */

	unsigned int	locked:1,	/* timer is only accesibble by owner if set */

		klocked:1,	/* kernel lock (after START) */	

		check_again:1,

		check_blocked:1;

	bool	locked;		/* timer is only accesibble by owner if set */

	bool	klocked;	/* kernel lock (after START) */

	bool	check_again;	/* concurrent access happened during check */

	bool	check_blocked;	/* queue being checked */



	unsigned int flags;		/* status flags */

	unsigned int info_flags;	/* info for sync */