Commit 4eb5d4a5 authored by Xin Long's avatar Xin Long Committed by Jakub Kicinski
Browse files

udp: not remove the CRC flag from dev features when need_csum is false 



In __skb_udp_tunnel_segment(), when it's a SCTP over VxLAN/GENEVE
packet and need_csum is false, which means the outer udp checksum
doesn't need to be computed, csum_start and csum_offset could be
used by the inner SCTP CRC CSUM for SCTP HW CRC offload.

So this patch is to not remove the CRC flag from dev features when
need_csum is false.

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/1e81b700642498546eaa3f298e023fd7ad394f85.1610776757.git.lucien.xin@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7baf2429

net/ipv4/udp_offload.c

+2 −2
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb, 
				      (NETIF_F_HW_CSUM | NETIF_F_IP_CSUM))));



	features &= skb->dev->hw_enc_features;

	/* CRC checksum can't be handled by HW when it's a UDP tunneling packet. */

	if (need_csum)

		features &= ~NETIF_F_SCTP_CRC;



	/* The only checksum offload we care about from here on out is the