Commit 4eb1d85c authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Greg Kroah-Hartman
Browse files

coresight: tpiu: Prepare for using coresight device access abstraction 

Prepare the TPIU driver to make use of the CoreSight device access
abstraction layer. The driver touches the device even before the
coresight device is registered. Thus we could be accessing the
devices without a csdev. As we are about to use the abstraction
layer for accessing the device, pass in the access directly
to avoid having to deal with the un-initialised csdev.

Link: https://lore.kernel.org/r/20210110224850.1880240-5-suzuki.poulose@arm.com


Cc: Mike Leach <mike.leach@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20210201181351.1475223-7-mathieu.poirier@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6e736c60

drivers/hwtracing/coresight/coresight-tpiu.c

+13 −17
Original line number Diff line number Diff line
@@ -60,49 +60,45 @@ struct tpiu_drvdata { 
	struct coresight_device	*csdev;

};



static void tpiu_enable_hw(struct tpiu_drvdata *drvdata)

static void tpiu_enable_hw(struct csdev_access *csa)

{

	CS_UNLOCK(drvdata->base);

	CS_UNLOCK(csa->base);



	/* TODO: fill this up */



	CS_LOCK(drvdata->base);

	CS_LOCK(csa->base);

}



static int tpiu_enable(struct coresight_device *csdev, u32 mode, void *__unused)

{

	struct tpiu_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);



	tpiu_enable_hw(drvdata);

	tpiu_enable_hw(&csdev->access);

	atomic_inc(csdev->refcnt);

	dev_dbg(&csdev->dev, "TPIU enabled\n");

	return 0;

}



static void tpiu_disable_hw(struct tpiu_drvdata *drvdata)

static void tpiu_disable_hw(struct csdev_access *csa)

{

	CS_UNLOCK(drvdata->base);

	CS_UNLOCK(csa->base);



	/* Clear formatter and stop on flush */

	writel_relaxed(FFCR_STOP_FI, drvdata->base + TPIU_FFCR);

	csdev_access_relaxed_write32(csa, FFCR_STOP_FI, TPIU_FFCR);

	/* Generate manual flush */

	writel_relaxed(FFCR_STOP_FI | FFCR_FON_MAN, drvdata->base + TPIU_FFCR);

	csdev_access_relaxed_write32(csa, FFCR_STOP_FI | FFCR_FON_MAN, TPIU_FFCR);

	/* Wait for flush to complete */

	coresight_timeout(drvdata->base, TPIU_FFCR, FFCR_FON_MAN_BIT, 0);

	coresight_timeout(csa->base, TPIU_FFCR, FFCR_FON_MAN_BIT, 0);

	/* Wait for formatter to stop */

	coresight_timeout(drvdata->base, TPIU_FFSR, FFSR_FT_STOPPED_BIT, 1);

	coresight_timeout(csa->base, TPIU_FFSR, FFSR_FT_STOPPED_BIT, 1);



	CS_LOCK(drvdata->base);

	CS_LOCK(csa->base);

}



static int tpiu_disable(struct coresight_device *csdev)

{

	struct tpiu_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);



	if (atomic_dec_return(csdev->refcnt))

		return -EBUSY;



	tpiu_disable_hw(drvdata);

	tpiu_disable_hw(&csdev->access);



	dev_dbg(&csdev->dev, "TPIU disabled\n");

	return 0;
@@ -152,7 +148,7 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) 
	desc.access = CSDEV_ACCESS_IOMEM(base);



	/* Disable tpiu to support older devices */

	tpiu_disable_hw(drvdata);

	tpiu_disable_hw(&desc.access);



	pdata = coresight_get_platform_data(dev);

	if (IS_ERR(pdata))