Commit 4eaf02d6 authored by Christian König's avatar Christian König
Browse files

drm/scheduler: fix drm_sched_job_add_implicit_dependencies 



Trivial fix since we now need to grab a reference to the fence we have
added. Previously the dma_resv function where doing that for us.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Fixes: 9c2ba265 ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2")
Link: https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koenig@amd.com


Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Reported-by: default avatarNicolas Frattaroli <frattaroli.nicolas@gmail.com>
References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/


Tested-by: default avatarNicolas Frattaroli <frattaroli.nicolas@gmail.com>
Tested-by: default avatarYassine Oudjana <y.oudjana@protonmail.com>
parent 467dd91e

drivers/gpu/drm/scheduler/sched_main.c

+3 −0
Original line number Diff line number Diff line
@@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job, 
		ret = drm_sched_job_add_dependency(job, fence);

		if (ret)

			return ret;



		/* Make sure to grab an additional ref on the added fence */

		dma_fence_get(fence);

	}

	return 0;

}