Commit 4e60d5dd authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Wolfram Sang
Browse files

i2c: i801: Improve disabling runtime pm 



Setting the autosuspend delay to a negative value disables runtime pm in
a little bit smarter way, because we need no cleanup when removing the
driver. Note that this is safe when reloading the driver, because the
call to pm_runtime_set_autosuspend_delay() in probe() will reverse the
effect. See update_autosuspend() for details.

Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent f16a3bb6

drivers/i2c/busses/i2c-i801.c

+1 −6
Original line number Diff line number Diff line
@@ -1628,7 +1628,7 @@ i801_acpi_io_handler(u32 function, acpi_physical_address address, u32 bits, 
		 * BIOS is accessing the host controller so prevent it from

		 * suspending automatically from now on.

		 */

		pm_runtime_get_sync(&pdev->dev);

		pm_runtime_set_autosuspend_delay(&pdev->dev, -1);

	}



	if ((function & ACPI_IO_MASK) == ACPI_READ)
@@ -1668,11 +1668,6 @@ static void i801_acpi_remove(struct i801_priv *priv) 


	acpi_remove_address_space_handler(adev->handle,

		ACPI_ADR_SPACE_SYSTEM_IO, i801_acpi_io_handler);



	mutex_lock(&priv->acpi_lock);

	if (priv->acpi_reserved)

		pm_runtime_put(&priv->pci_dev->dev);

	mutex_unlock(&priv->acpi_lock);

}

#else

static inline int i801_acpi_probe(struct i801_priv *priv) { return 0; }