Commit 4e5973dd authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Joerg Roedel
Browse files

iommu/vt-d: Fix an unbalanced rcu_read_lock/rcu_read_unlock() 



If we return -EOPNOTSUPP, the rcu lock remains lock. This is spurious.
Go through the end of the function instead. This way, the missing
'rcu_read_unlock()' is called.

Fixes: 7afd7f6a ("iommu/vt-d: Check FL and SL capability sanity in scalable mode")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/40cc077ca5f543614eab2a10e84d29dd190273f6.1636217517.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20211126135556.397932-2-baolu.lu@linux.intel.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent f7ff3cff

drivers/iommu/intel/cap_audit.c

+3 −2
Original line number Diff line number Diff line
@@ -144,6 +144,7 @@ static int cap_audit_static(struct intel_iommu *iommu, enum cap_audit_type type) 
{

	struct dmar_drhd_unit *d;

	struct intel_iommu *i;

	int rc = 0;



	rcu_read_lock();

	if (list_empty(&dmar_drhd_units))
@@ -169,11 +170,11 @@ static int cap_audit_static(struct intel_iommu *iommu, enum cap_audit_type type) 
	 */

	if (intel_cap_smts_sanity() &&

	    !intel_cap_flts_sanity() && !intel_cap_slts_sanity())

		return -EOPNOTSUPP;

		rc = -EOPNOTSUPP;



out:

	rcu_read_unlock();

	return 0;

	return rc;

}



int intel_cap_audit(enum cap_audit_type type, struct intel_iommu *iommu)