Commit 4e4b1798 authored by Benjamin Poirier's avatar Benjamin Poirier Committed by David S. Miller
Browse files

vxlan: Add missing entries to vxlan_get_size() 



There are some attributes added by vxlan_fill_info() which are not
accounted for in vxlan_get_size(). Add them.

I didn't find a way to trigger an actual problem from this miscalculation
since there is usually extra space in netlink size calculations like
if_nlmsg_size(); but maybe I just didn't search long enough.

Fixes: 3511494c ("vxlan: Group Policy extension")
Fixes: e1e5314d ("vxlan: implement GPE")
Fixes: 0ace2ca8 ("vxlan: Use checksum partial with remote checksum offload")
Fixes: f9c4bb0b ("vxlan: vni filtering support on collect metadata device")
Signed-off-by: default avatarBenjamin Poirier <bpoirier@nvidia.com>
Acked-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f1d95df0

drivers/net/vxlan/vxlan_core.c

+4 −0
Original line number Diff line number Diff line
@@ -4331,6 +4331,10 @@ static size_t vxlan_get_size(const struct net_device *dev) 
		nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_TX */

		nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_RX */

		nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_LOCALBYPASS */

		nla_total_size(0) + /* IFLA_VXLAN_GBP */

		nla_total_size(0) + /* IFLA_VXLAN_GPE */

		nla_total_size(0) + /* IFLA_VXLAN_REMCSUM_NOPARTIAL */

		nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_VNIFILTER */

		0;

}