Commit 4dd8752a authored by Johan Hovold's avatar Johan Hovold Committed by Rafael J. Wysocki
Browse files

serial: qcom-geni: drop bogus runtime pm state update 



The runtime PM state should not be changed by drivers that do not
implement runtime PM even if it happens to work around a bug in PM core.

With the wake irq arming now fixed, drop the bogus runtime PM state
update which left the device in active state (and could potentially
prevent a parent device from suspending).

Fixes: f3974413 ("tty: serial: qcom_geni_serial: Wakeup IRQ cleanup")
Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent e7b91521

drivers/tty/serial/qcom_geni_serial.c

+0 −7
Original line number Diff line number Diff line
@@ -1681,13 +1681,6 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	/*

	 * Set pm_runtime status as ACTIVE so that wakeup_irq gets

	 * enabled/disabled from dev_pm_arm_wake_irq during system

	 * suspend/resume respectively.

	 */

	pm_runtime_set_active(&pdev->dev);



	if (port->wakeup_irq > 0) {

		device_init_wakeup(&pdev->dev, true);

		ret = dev_pm_set_dedicated_wake_irq(&pdev->dev,