Commit 4dbd6e61 authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Fix a missing cleanup path 



On systems that support slider notifications but don't otherwise support
granular slider the SPS cleanup path doesn't run.

This means that loading/unloading/loading leads to failures because
the sysfs files don't get setup properly when reloaded.

Add the missing cleanup path.

Fixes: 33c9ab5b ("platform/x86/amd/pmf: Notify OS power slider update")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230823185421.23959-1-mario.limonciello@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 39ab0baf

drivers/platform/x86/amd/pmf/core.c

+2 −1
Original line number Diff line number Diff line
@@ -324,7 +324,8 @@ static void amd_pmf_init_features(struct amd_pmf_dev *dev) 


static void amd_pmf_deinit_features(struct amd_pmf_dev *dev)

{

	if (is_apmf_func_supported(dev, APMF_FUNC_STATIC_SLIDER_GRANULAR)) {

	if (is_apmf_func_supported(dev, APMF_FUNC_STATIC_SLIDER_GRANULAR) ||

	    is_apmf_func_supported(dev, APMF_FUNC_OS_POWER_SLIDER_UPDATE)) {

		power_supply_unreg_notifier(&dev->pwr_src_notifier);

		amd_pmf_deinit_sps(dev);

	}