Commit 4dbd2920 authored by David Hildenbrand's avatar David Hildenbrand Committed by Kefeng Wang
Browse files

mm/rmap: silence VM_WARN_ON_FOLIO() in __folio_rmap_sanity_checks() 

mainline inclusion
from mainline-v6.8-rc1
commit 9c5938694cd0e9e00bdfb7e60900673263daf4d5
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I9CESE
CVE: NA

-------------------------------------------------

Unfortunately, vm_insert_page() and friends and up passing
driver-allocated folios into folio_add_file_rmap_pte() using
insert_page_into_pte_locked().

While these driver-allocated folios can be compound pages (large folios),
they are not proper "rmappable" folios.

In these VM_MIXEDMAP VMAs, there isn't really the concept of a reverse
mapping, so long-term, we should clean that up and not call into rmap
code.

For the time being, document how we can end up in rmap code with large
folios that are not marked rmappable.

Link: https://lkml.kernel.org/r/793c5cee-d5fc-4eb1-86a2-39e05686233d@redhat.com


Fixes: 68f0320824fa ("mm/rmap: convert folio_add_file_rmap_range() into folio_add_file_rmap_[pte|ptes|pmd]()")
Reported-by: default avatar <syzbot+50ef73537bbc393a25bb@syzkaller.appspotmail.com>
Closes: https://lkml.kernel.org/r/000000000000014174060e09316e@google.com


Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Yin Fengwei <fengwei.yin@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
(cherry picked from commit 9c5938694cd0e9e00bdfb7e60900673263daf4d5)
Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
parent 9ac18279

include/linux/rmap.h

+9 −2
Original line number Diff line number Diff line
@@ -194,8 +194,15 @@ static inline void __folio_rmap_sanity_checks(struct folio *folio, 
{

	/* hugetlb folios are handled separately. */

	VM_WARN_ON_FOLIO(folio_test_hugetlb(folio), folio);

	VM_WARN_ON_FOLIO(folio_test_large(folio) &&

			 !folio_test_large_rmappable(folio), folio);



	/*

	 * TODO: we get driver-allocated folios that have nothing to do with

	 * the rmap using vm_insert_page(); therefore, we cannot assume that

	 * folio_test_large_rmappable() holds for large folios. We should

	 * handle any desired mapcount+stats accounting for these folios in

	 * VM_MIXEDMAP VMAs separately, and then sanity-check here that

	 * we really only get rmappable folios.

	 */



	VM_WARN_ON_ONCE(nr_pages <= 0);

	VM_WARN_ON_FOLIO(page_folio(page) != folio, folio);